Generate timestamp parsing that static analysis accepts without an annotation (#2132)

Author: Amoifr

src/Generator/ResponseParser/JsonRpcParser.php

@@ -16,7 +16,7 @@ class JsonRpcParser extends RestJsonParser
     protected function parseResponseTimestamp(Shape $shape, string $input, bool $required): string
     {
         if ($required) {
-            $body = '/** @var \DateTimeImmutable $d */ $d = \DateTimeImmutable::createFromFormat(\'U.u\', \sprintf(\'%.6F\', INPUT))';
+            $body = $this->rejectUnparsableTimestamp('\DateTimeImmutable::createFromFormat(\'U.u\', \sprintf(\'%.6F\', INPUT))');
         } else {
             $body = '(isset(INPUT) && ($d = \DateTimeImmutable::createFromFormat(\'U.u\', \sprintf(\'%.6F\', INPUT)))) ? $d : null';
         }

src/Generator/ResponseParser/RestJsonParser.php

@@ -19,6 +19,7 @@
 use AsyncAws\CodeGenerator\Generator\GeneratorHelper;
 use AsyncAws\CodeGenerator\Generator\Naming\ClassName;
 use AsyncAws\CodeGenerator\Generator\Naming\NamespaceRegistry;
+use AsyncAws\Core\Exception\UnparsableResponse;
 use Nette\PhpGenerator\Method;
 use Nette\PhpGenerator\Visibility;
 
@@ -161,14 +162,28 @@ protected function parseResponseTimestamp(Shape $shape, string $input, bool $req
         }
 
         if ($required) {
-            $body = '/** @var \DateTimeImmutable $d */ $d = ' . $body;
+            $body = $this->rejectUnparsableTimestamp($body);
         } else {
             $body = 'isset(INPUT) && ($d = ' . $body . ') ? $d : null';
         }
 
         return strtr($body, ['INPUT' => $input]);
     }
 
+    /**
+     * createFromFormat() returns false on a malformed value, and no annotation convinces static
+     * analysis that it cannot happen here. The failure is raised instead, so that the generated
+     * code needs no baseline entry: the value comes from the response, which is exactly what
+     * UnparsableResponse describes.
+     */
+    protected function rejectUnparsableTimestamp(string $body): string
+    {
+        $className = ClassName::createFromFqdn(UnparsableResponse::class);
+        $this->imports[] = $className;
+
+        return $body . ' ?: throw new ' . $className->getName() . "('Invalid timestamp received.')";
+    }
+
     private function getInputAccessorName(Member $member): string
     {
         if ($member instanceof StructureMember) {