Add HTTP status detail to server errors

Co-authored-by: Grotax <5429298+Grotax@users.noreply.github.com>

Author: Copilot

CHANGELOG.md

@@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 ### Changed
-- Add isPermaLink=false support to setPublicId() - (#103)
+- Add isPermaLink=false support to setPublicId() (#103)
+- Return better error messages when remote responds with error code (#146)
 
 ### Fixed
 - fix: rewrite relative links in `content:encoded` and other optional elements, not only in `content`/`description` properties

src/FeedIo/Adapter/ServerErrorException.php

@@ -12,10 +12,15 @@ public function __construct(
         protected ResponseInterface $response,
         float $duration = 0
     ) {
-        parent::__construct(
-            'internal server error',
-            $duration
+        $statusCode = $response->getStatusCode();
+        $reasonPhrase = trim($response->getReasonPhrase());
+        $message = sprintf(
+            'Server responded with: %d%s',
+            $statusCode,
+            $reasonPhrase !== '' ? ' ' . $reasonPhrase : ''
         );
+
+        parent::__construct($message, $duration);
     }
 
     public function getResponse(): ResponseInterface

tests/FeedIo/Adapter/Http/ClientTest.php

@@ -105,6 +105,22 @@ public function testGetResponseThrowsServerErrorOnServerError(): void
             ->willReturn($psrResponse);
 
         $this->expectException(ServerErrorException::class);
+        $this->expectExceptionMessage('Server responded with: 500 Internal Server Error');
+
+        $this->client->getResponse('https://example.com/feed.xml');
+    }
+
+    public function testGetResponseThrowsServerErrorOnForbidden(): void
+    {
+        $psrResponse = new PsrResponse(403, [], 'Forbidden');
+
+        $this->psrClient
+            ->expects($this->once())
+            ->method('sendRequest')
+            ->willReturn($psrResponse);
+
+        $this->expectException(ServerErrorException::class);
+        $this->expectExceptionMessage('Server responded with: 403 Forbidden');
 
         $this->client->getResponse('https://example.com/feed.xml');
     }

tests/FeedIo/ReaderTest.php

@@ -52,6 +52,9 @@ protected function getClientMock()
     protected function getFaultyClientMock()
     {
         $response = $this->createMock('Psr\Http\Message\ResponseInterface');
+        $response->method('getStatusCode')->willReturn(403);
+        $response->method('getReasonPhrase')->willReturn('Forbidden');
+
         $client = $this->createMock('FeedIo\Adapter\ClientInterface');
         $client->expects($this->any())->method('getResponse')->willThrowException(
             new ServerErrorException($response, 0)