Typescript: how to filter operation when extend prisma and $allOperations

[meotimdihia]

Typescript: how to filter operation when extend prisma and $allOperations.
It works if I filter for create or update only. But I don't how to avoid duplicate code when extending both create and update too.

const xprisma = prisma
  .$extends({
    query: {
      md_chapters: {
        async $allOperations({ args, query, operation, model }) {
          const cur = await query(args)
          if (operation == "create" || operation == "update") {
            if (cur.status == "OK" || cur.status == "waiting") {
            ....
         }
     }
  })

Also please add examples to the documentation. I think it is very useful.

[nurul3101]

Hello @meotimdihia 👋

I am not able to understand the exact issue you are facing. Do you mind elaborating?

Also please add examples to the documentation. I think it is very useful.

Did you had a chance to look at this section of examples?

[meotimdihia]

Hi @millsp , the problem is I want to avoid duplicated code, but I don't know how to handle it.

I edited the code in this file: https://github.com/prisma/prisma-client-extensions/blob/main/model-filters/script.ts

If you have a solution please help me to edit the code:

import { Prisma, PrismaClient } from "@prisma/client";
import { sub } from "date-fns";

const prisma = new PrismaClient({ log: ["query"] })
  .$extends({
    query: {
      post: {
        async $allOperations({ args, query, operation, model }) {
          if (operation != "create" && operation != "update") {
            return await query(args);
          }

          // 1
          // works fine but duplicated code
          if (operation == "create") {
            const cur = await query(args);
            await prisma.post.update({
              data: {
                title: "abcedf",
              },
              where: {
                id: cur.id,
              },
            });
          }

          // works fine but duplicated code
          if (operation == "update") {
            const cur = await query(args);
            await prisma.post.update({
              data: {
                title: "abcedf",
              },
              where: {
                id: cur.id,
              },
            });
          }

          // 2
          // doesn't work, we need a solution for this problem 

          if (operation == "create" || operation == "update") {
            const cur = await query(args);

            await prisma.post.update({
              data: {
                title: "abcedf",
              },
              where: {
                id: cur.id, // Property 'id' does not exist on type 'number | PayloadToResult<PostPayload<DefaultArgs>, // RenameAndNestPayloadKeys<PostPayload<DefaultArgs>>> | ... 4 more ... | Optional<...>'.
//  Property 'id' does not exist on type 'number'.ts(2339)
              },
            });
          }
        },
      },
    },
  })
  .$extends({
    model: {
      post: {
        unpublished: () => ({ published: false }),
        published: () => ({ published: true }),
        byAuthor: (authorId: string) => ({ authorId }),
        byAuthorDomain: (domain: string) => ({
          author: { email: { endsWith: `@${domain}` } },
        }),
        hasComments: () => ({ comments: { some: {} } }),
        hasRecentComments: (date: Date) => ({
          comments: { some: { createdAt: { gte: date } } },
        }),
        titleContains: (search: string) => ({ title: { contains: search } }),
      } satisfies Record<string, (...args: any) => Prisma.PostWhereInput>,
    },
  });

async function main() {
  const posts = await prisma.post.findMany({
    where: {
      AND: [
        prisma.post.published(),
        prisma.post.byAuthorDomain("prisma.io"),
        prisma.post.hasRecentComments(sub(new Date(), { weeks: 1 })),
        prisma.post.titleContains("GraphQL"),
      ],
    },
  });
}

main()
  .then(async () => {
    await prisma.$disconnect();
  })
  .catch(async (e) => {
    console.error(e);
    await prisma.$disconnect();
    process.exit(1);
  });

[millsp]

Right, thanks. I think I see what the problem is now. I believe this could be related to this issue. I'll get back to you when it is merged.

[millsp]

Hey @meotimdihia, I just gave your issue a try with some recent fixes we merged. Your's is something else, and is an improvement that we could do. I took the time to understand what this change would mean and it sounds like a good idea, so that you can have better narrowing. In some cases we could also consider this a bug, because it is surprising that it works this way. This boils down to the way TypeScript works and the concept of variance, and ideally I'd like that our users needn't worry about this.

[millsp]

That said, I am not sure how this can be fixed without impacting autocompletion for the input. Could you please create a new issue, and we'll try to schedule work for it?

[meotimdihia]

@millsp thanks, I created the issue: #20395

[meotimdihia]

Does anyone have an answer to this question?

[ludralph]

Hi there,

To keep our discussions organized and focused on the most relevant topics, we’re reviewing and tidying up our backlog. As part of this process, we’re closing discussions that haven’t had any recent activity and appear to be outdated.

If this discussion is still important to you or unresolved, we’d love to hear from you! Feel free to reopen it or start a new one with updated details.

For more details about our priorities and vision for the future of Prisma ORM, check out our latest blog post: https://www.prisma.io/blog/prisma-orm-manifesto.

Thank you for your understanding and being part of the community!