Merge pull request #36320 from storybookjs/fix/node-prerelease-version-gate

CLI: Accept Node.js prerelease builds in the version gate

Author: obvious-autobuild[bot]

code/core/src/bin/dispatcher.ts

@@ -23,8 +23,7 @@ import { resolvePackageDir } from '../shared/utils/module.ts';
  * - Init is routed to the create-storybook package via the detected package manager
  * - External CLI tools (upgrade, doctor, etc.) are routed to @storybook/cli the same way
  */
-const [major, minor, patch] = process.versions.node.split('.').map(Number);
-if (!isNodeVersionSupported(major, minor, patch)) {
+if (!isNodeVersionSupported(process.versions.node)) {
   logger.error(
     dedent`To run Storybook, you need Node.js version ${MIN_SUPPORTED_NODE_DESCRIPTION}.
     You are currently running Node.js ${process.version}. Please upgrade your Node.js installation.`

code/core/src/common/node-version.test.ts

@@ -29,48 +29,52 @@ describe('node-version', () => {
   });
 
   describe('isNodeVersionSupported', () => {
-    it('rejects 20.19.0 (below minimum major)', () => {
-      expect(isNodeVersionSupported(20, 19, 0)).toBe(false);
+    it('accepts exact minimum version (22.12.0)', () => {
+      expect(isNodeVersionSupported('22.12.0')).toBe(true);
     });
 
-    it('accepts exact minimum version (22.12.0)', () => {
-      expect(isNodeVersionSupported(22, 12, 0)).toBe(true);
+    it('accepts 22.12.1 (patch above minimum)', () => {
+      expect(isNodeVersionSupported('22.12.1')).toBe(true);
     });
 
-    it('rejects version below minimum minor (20.18.0)', () => {
-      expect(isNodeVersionSupported(20, 18, 0)).toBe(false);
+    it('accepts future major above highest defined (24.0.0)', () => {
+      expect(isNodeVersionSupported('24.0.0')).toBe(true);
     });
 
-    it('rejects version below minimum major (18.0.0)', () => {
-      expect(isNodeVersionSupported(18, 0, 0)).toBe(false);
+    it('accepts prerelease of a supported version (26.1.0-rc.0)', () => {
+      expect(isNodeVersionSupported('26.1.0-rc.0')).toBe(true);
     });
 
-    it('rejects 20.20.0 (below minimum major)', () => {
-      expect(isNodeVersionSupported(20, 20, 0)).toBe(false);
+    it('accepts prerelease of a future major (27.0.0-alpha.1)', () => {
+      expect(isNodeVersionSupported('27.0.0-alpha.1')).toBe(true);
     });
 
-    it('rejects 21.0.0 (below minimum major)', () => {
-      expect(isNodeVersionSupported(21, 0, 0)).toBe(false);
+    it('accepts nightly builds (26.0.0-nightly20260915abc1234)', () => {
+      expect(isNodeVersionSupported('26.0.0-nightly20260915abc1234')).toBe(true);
     });
 
-    it('accepts future major above highest defined (24.0.0)', () => {
-      expect(isNodeVersionSupported(24, 0, 0)).toBe(true);
+    it('rejects a prerelease below the minimum (22.12.0-rc.0)', () => {
+      expect(isNodeVersionSupported('22.12.0-rc.0')).toBe(false);
     });
 
     it('rejects 22.11.0 (one minor below 22.12)', () => {
-      expect(isNodeVersionSupported(22, 11, 0)).toBe(false);
+      expect(isNodeVersionSupported('22.11.0')).toBe(false);
     });
 
-    it('accepts 22.12.1 (patch above minimum)', () => {
-      expect(isNodeVersionSupported(22, 12, 1)).toBe(true);
+    it('rejects 20.19.0 (below minimum major)', () => {
+      expect(isNodeVersionSupported('20.19.0')).toBe(false);
+    });
+
+    it('rejects 21.0.0 (below minimum major)', () => {
+      expect(isNodeVersionSupported('21.0.0')).toBe(false);
     });
 
-    it('rejects 19.99.99', () => {
-      expect(isNodeVersionSupported(19, 99, 99)).toBe(false);
+    it('rejects 18.0.0 (below minimum major)', () => {
+      expect(isNodeVersionSupported('18.0.0')).toBe(false);
     });
 
-    it('rejects major-only "22" (treated as 22.0.0 which is below 22.12)', () => {
-      expect(isNodeVersionSupported(22, 0, 0)).toBe(false);
+    it('fails closed for unparseable input (not-a-version)', () => {
+      expect(isNodeVersionSupported('not-a-version')).toBe(false);
     });
   });
 

code/core/src/common/node-version.ts

@@ -35,11 +35,13 @@ export const MIN_SUPPORTED_NODE_DESCRIPTION =
   MIN_SUPPORTED_NODE_VERSIONS.map(formatMinVersion).join(' or ');
 
 /**
- * Check whether a Node.js version (major.minor.patch) meets the minimum requirement.
+ * Check whether a Node.js version meets the minimum requirement.
  *
- * Missing version components should be normalized by callers (e.g. "22" -> 22.0.0).
+ * Expects the raw `process.versions.node` value (e.g. "22.12.0", "26.1.0-rc.0").
+ * Prerelease builds are evaluated with semver's prerelease rules, so a prerelease
+ * below the floor (e.g. "22.12.0-rc.0") still fails. Unparseable input fails closed.
  */
-export function isNodeVersionSupported(major: number, minor: number, patch: number): boolean {
+export function isNodeVersionSupported(version: string): boolean {
   const sortedMinimums = [...MIN_SUPPORTED_NODE_VERSIONS].sort((a, b) => a.major - b.major);
   const supportedRange = sortedMinimums
     .map((min, index) => {
@@ -54,5 +56,5 @@ export function isNodeVersionSupported(major: number, minor: number, patch: numb
     })
     .join(' || ');
 
-  return satisfies(`${major}.${minor}.${patch}`, supportedRange);
+  return satisfies(version, supportedRange, { includePrerelease: true });
 }

code/lib/cli-storybook/src/autoblock/block-node-version.test.ts

@@ -14,13 +14,16 @@ describe('minimumNode22 blocker', () => {
     stubNodeVersion(originalNodeVersion);
   });
 
-  test.each(['20.19.0', '21.7.3', '22.11.0'])('blocks Node.js %s', async (version) => {
-    stubNodeVersion(version);
-    const options = {} as AutoblockOptions;
-    await expect(blocker.check(options)).resolves.toEqual({ nodeVersion: version });
-  });
-
-  test.each(['22.12.0', '24.1.0'])('does not block Node.js %s', async (version) => {
+  test.each(['20.19.0', '21.7.3', '22.11.0', '20.0.0-rc.0', '22.12.0-rc.1'])(
+    'blocks Node.js %s',
+    async (version) => {
+      stubNodeVersion(version);
+      const options = {} as AutoblockOptions;
+      await expect(blocker.check(options)).resolves.toEqual({ nodeVersion: version });
+    }
+  );
+
+  test.each(['22.12.0', '24.1.0', '22.13.0-rc.1'])('does not block Node.js %s', async (version) => {
     stubNodeVersion(version);
     const options = {} as AutoblockOptions;
     await expect(blocker.check(options)).resolves.toBe(false);

code/lib/cli-storybook/src/autoblock/block-node-version.ts

@@ -6,11 +6,8 @@ export const blocker = createBlocker({
   id: 'minimumNode22',
   async check() {
     const nodeVersion = process.versions.node;
-    if (nodeVersion) {
-      const [major, minor, patch] = nodeVersion.split('.').map(Number);
-      if (!isNodeVersionSupported(major, minor, patch)) {
-        return { nodeVersion };
-      }
+    if (nodeVersion && !isNodeVersionSupported(nodeVersion)) {
+      return { nodeVersion };
     }
     return false;
   },

code/lib/cli-storybook/src/bin/index.ts

@@ -4,9 +4,7 @@ import { logger } from 'storybook/internal/node-logger';
 
 import { dedent } from 'ts-dedent';
 
-const [major, minor, patch] = process.versions.node.split('.').map(Number);
-
-if (!isNodeVersionSupported(major, minor, patch)) {
+if (!isNodeVersionSupported(process.versions.node)) {
   logger.error(
     dedent`To run Storybook, you need Node.js version ${MIN_SUPPORTED_NODE_DESCRIPTION}.
       You are currently running Node.js ${process.version}. Please upgrade your Node.js installation.`

code/lib/create-storybook/src/bin/index.ts

@@ -2,9 +2,8 @@
 export {};
 
 const { isNodeVersionSupported } = await import('storybook/internal/common');
-const [major, minor, patch] = process.versions.node.split('.').map(Number);
 
-if (!isNodeVersionSupported(major, minor, patch)) {
+if (!isNodeVersionSupported(process.versions.node)) {
   const { MIN_SUPPORTED_NODE_DESCRIPTION } = await import('storybook/internal/common');
   const { logger } = await import('storybook/internal/node-logger');
   logger.error(