Skip to content

feat(editor): show the number of columns in the result status bar - #1057

Open
batool-fariha wants to merge 1 commit into
TabularisDB:mainfrom
batool-fariha:feat/result-status-column-count
Open

batool-fariha wants to merge 1 commit into
TabularisDB:mainfrom
batool-fariha:feat/result-status-column-count

Conversation

@batool-fariha

Copy link
Copy Markdown

Closes #1035

What changed

  • The status bar of a result now shows the number of columns next to the row count, for example 120 rows retrieved · 8 columns.
  • It appears in all three places the issue names: the single result bar in src/pages/Editor.tsx, the result entry in src/components/ui/ResultEntryContent.tsx, and the header of a stacked result in src/components/ui/StackedResultItem.tsx.
  • It hides in narrow panes with the duration (hidden @[400px]:inline). A statement without a result set (no columns) is unchanged.
  • New key editor.columnsCount with plural forms in every locale: _one and _other, and _few and _many for Russian. I wrote the translations myself. A native speaker should check them, most of all Tagalog, where I kept the English word column.

Tests

  • New tests/components/ui/ResultStatusColumnCount.test.tsx: the count in a result entry, the count in a stacked result, and no count for a statement without columns. It checks the count that t receives. The shared i18n mock returns the bare key, so this file sets its own mock. The first two tests fail without the change.
  • pnpm test passes (356 files, 5,749 tests). pnpm lint and pnpm typecheck pass.
  • I did not run the desktop app and look at the bar.

Notes

  • feat(editor): show server time and fetch time separately in result status bar (#990) #1021 edits the same status-bar lines, as the issue says. I will rebase when it merges.
  • I could not run the GitNexus impact and detect_changes steps from AGENTS.md: those tools are not available in my session. The edit only adds a conditional element to three status bars. I did not change a function signature.
  • Claude helped to write this change. I ran and checked the tests.

🤖 Generated with Claude Code

The status bar of a result showed the row count only. A SELECT * or a
join can scroll sideways, so the width of the result was not clear.
Show "N rows retrieved · M columns" in the single result bar, in the
multi-result panel, and in the header of a stacked result. The column
count hides in narrow panes with the duration, and a statement without
a result set is unchanged. The new key has plural forms in every locale.

Closes TabularisDB#1035

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kilo-code-bot

kilo-code-bot Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (15 files)
  • src/components/ui/ResultEntryContent.tsx
  • src/components/ui/StackedResultItem.tsx
  • src/i18n/locales/de.json
  • src/i18n/locales/en.json
  • src/i18n/locales/es.json
  • src/i18n/locales/fr.json
  • src/i18n/locales/it.json
  • src/i18n/locales/ja.json
  • src/i18n/locales/ko.json
  • src/i18n/locales/pt-BR.json
  • src/i18n/locales/ru.json
  • src/i18n/locales/tl.json
  • src/i18n/locales/zh.json
  • src/pages/Editor.tsx
  • tests/components/ui/ResultStatusColumnCount.test.tsx

Reviewed by free · Input: 77.8K · Output: 2K · Cached: 40.9K

@debba debba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fariha, and welcome to Tabularis! This covers #1035 completely: all three status bars, the count hidden in narrow panes with the same @[400px]: rule as the duration, and nothing shown for statements without a result set. I really appreciated the proper plural forms everywhere, including _few / _many for Russian, and that you were upfront about which translations need a native check and that you didn't run the desktop app. The local i18n mock that returns key:count is a clever way to assert the count actually reaches t, since the shared mock would hide that. Lint, typecheck and the full vitest suite pass on the branch.

As you noted, #1021 touches the same lines. That one still needs some changes, so whichever lands second will need a small rebase. No action needed from you right now.

Since this is your first PR here: this week we're running a giveaway on our Discord, open until October 13, with 3 seats in our Claude Team up for grabs. If you'd like to join, you're very welcome: https://discord.com/invite/K2hmhfHRSt

Nothing blocking from my side. I'll run some e2e tests on the real app for a final check and then go ahead with the merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Result status bar: show the number of columns

2 participants