Repository navigation
feat(editor): show the number of columns in the result status bar - #1057
batool-fariha wants to merge 1 commit into
Conversation
The status bar of a result showed the row count only. A SELECT * or a join can scroll sideways, so the width of the result was not clear. Show "N rows retrieved · M columns" in the single result bar, in the multi-result panel, and in the header of a stacked result. The column count hides in narrow panes with the duration, and a statement without a result set is unchanged. The new key has plural forms in every locale. Closes TabularisDB#1035 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (15 files)
Reviewed by free · Input: 77.8K · Output: 2K · Cached: 40.9K |
debba
left a comment
There was a problem hiding this comment.
Thanks Fariha, and welcome to Tabularis! This covers #1035 completely: all three status bars, the count hidden in narrow panes with the same @[400px]: rule as the duration, and nothing shown for statements without a result set. I really appreciated the proper plural forms everywhere, including _few / _many for Russian, and that you were upfront about which translations need a native check and that you didn't run the desktop app. The local i18n mock that returns key:count is a clever way to assert the count actually reaches t, since the shared mock would hide that. Lint, typecheck and the full vitest suite pass on the branch.
As you noted, #1021 touches the same lines. That one still needs some changes, so whichever lands second will need a small rebase. No action needed from you right now.
Since this is your first PR here: this week we're running a giveaway on our Discord, open until October 13, with 3 seats in our Claude Team up for grabs. If you'd like to join, you're very welcome: https://discord.com/invite/K2hmhfHRSt
Nothing blocking from my side. I'll run some e2e tests on the real app for a final check and then go ahead with the merge.
Closes #1035
What changed
120 rows retrieved · 8 columns.src/pages/Editor.tsx, the result entry insrc/components/ui/ResultEntryContent.tsx, and the header of a stacked result insrc/components/ui/StackedResultItem.tsx.hidden @[400px]:inline). A statement without a result set (no columns) is unchanged.editor.columnsCountwith plural forms in every locale:_oneand_other, and_fewand_manyfor Russian. I wrote the translations myself. A native speaker should check them, most of all Tagalog, where I kept the English wordcolumn.Tests
tests/components/ui/ResultStatusColumnCount.test.tsx: the count in a result entry, the count in a stacked result, and no count for a statement without columns. It checks the count thattreceives. The shared i18n mock returns the bare key, so this file sets its own mock. The first two tests fail without the change.pnpm testpasses (356 files, 5,749 tests).pnpm lintandpnpm typecheckpass.Notes
impactanddetect_changessteps fromAGENTS.md: those tools are not available in my session. The edit only adds a conditional element to three status bars. I did not change a function signature.🤖 Generated with Claude Code