Repository navigation
fix: use --config.prod escape hatch for pnpm compatibility - #24
Merged
Merged
Conversation
pnpm >=12.4.1 routes `install <pkg>` through its `add`-compatible argument parser, which rejects the `--prod`/`--no-prod` boolean flag and makes installPackage() fail entirely. Switch to the `--config.` escape hatch, which bypasses per-command flag validation and works across pnpm 11 and 12. Fixes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm >=12.4.1 routes
pnpm install <pkg>through itsadd-compatible argument parser (pnpm/pnpm#13888), which doesn't accept the--prod/--no-prodboolean flag we relied on to stop pnpm from removing devDependencies whileNODE_ENV=production. This makes everyinstallPackage()call using pnpm fail:See pnpm/pnpm#14868 for the upstream report.
Fix
Replace
--prod=falsewith pnpm's--config.prod=falseescape hatch, which bypasses per-command flag validation entirely and sets the same underlying config value. Verified against pnpm 11.15.1 and 12.4.1 that:installPackage()succeeds on pnpm 12.4.1NODE_ENV=productionFixes #23
This PR was created with the help of an agent.