Repository navigation
GH-53518: [Parquet] Reject unsupported compression codecs - #53522
Open
divjotarora wants to merge 1 commit into
Open
divjotarora wants to merge 1 commit into
divjotarora wants to merge 1 commit into
Conversation
|
|
divjotarora
force-pushed
the
fix-codecs
branch
from
October 13, 2026 09:56
89ba4c8 to
c0ed892
Compare
divjotarora
force-pushed
the
fix-codecs
branch
from
October 13, 2026 09:59
c0ed892 to
ab00ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #53518 for rationale. Treating unknown compression codecs as
UNCOMPRESSEDis wrong and at best causes the read to fail late during decoding and at worst yields incorrect results if the compressed stream is actually a valid decodable set of bytes (very unlikely).What changes are included in this PR?
This PR causes unsupported compression codecs to fail a read eagerly during Thrift parsing.
Are these changes tested?
Yes, new test case added to
metadata_test.ccAre there any user-facing changes?
No
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by:
Closes #53518