Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3299 +/- ##
============================================
- Coverage 41.92% 41.71% -0.22%
+ Complexity 7101 7037 -64
============================================
Files 770 762 -8
Lines 67320 67066 -254
Branches 9042 9022 -20
============================================
- Hits 28226 27974 -252
- Misses 35879 35880 +1
+ Partials 3215 3212 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
contrueCT
marked this pull request as draft
October 9, 2026 13:52
14 of 69 tasks
contrueCT
force-pushed
the
fix/topling-olap-clear
branch
from
October 10, 2026 04:44
a440bdc to
6a068b9
Compare
contrueCT
marked this pull request as ready for review
October 10, 2026 04:50
Clear OLAP data without dropping its column family. Route the clear to the owning database under the store lock. Discard only the clearing threads pending batch. Cover handle identity, other tables, reuse and reopen.
contrueCT
force-pushed
the
fix/topling-olap-clear
branch
from
October 10, 2026 11:58
6a068b9 to
34cc360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Topling's standalone OLAP property clear still drops and recreates the same column family. The previously reported real-JNI reproduction completes the clear task, then aborts during normal shutdown. This change clears the selected table while retaining its CF handle.
Addresses the OLAP clear/close item already tracked in #3242 and the original review. The release checklist stays open. Existing Topling and recovery PRs were checked; the merged runtime integration and snapshot-recovery fix #3293 do not cover this clear path.
Main Changes
AtomicReferenceowner introduced by merged fix(rocksdb): make snapshot restore retryable #3293.Verifying these changes
RocksDBSessionsTest: 28 tests pass on Java 17 after rebasing onto master87a06a9b, with no failures/errors/skips. New tests cover retained handle identity, repeated clears, pending writes outside the stored range and in an empty table, independent OLAP routing, other-table preservation, reuse and close/reopen reads.git diff --checkpass.These tests run the Topling Java branch with the real standard RocksDB JNI. The same handle-preservation regression fails against the original master adapter. Actual Topling JNI and its reported shutdown abort were not rerun on this macOS arm64 host; current-head Linux native qualification remains necessary.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - Done:docs/storage-lifecycle.mddocuments OLAP clear, handle retention and pending-write handling.Doc - No Need