Repository navigation
fix(common): verify HTTPS certificate identity - #3307
Merged
imbajin merged 2 commits intoOct 10, 2026
Merged
Conversation
- retain native OkHttp certificate hostname checks - preserve the public verifier signature and delegation - cover real HTTPS identity and trust failures - document matching DNS and IP SAN requirements
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3307 +/- ##
============================================
+ Coverage 41.71% 41.93% +0.22%
- Complexity 7036 7105 +69
============================================
Files 762 770 +8
Lines 67057 67320 +263
Branches 9021 9042 +21
============================================
+ Hits 27974 28234 +260
+ Misses 35872 35870 -2
- Partials 3211 3216 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Distinguish relocated shared types from core helpers - Document process namespace binding and conflicts - Clarify current distribution and archive cleanup
imbajin
force-pushed
the
fix/integration-tls-verification
branch
from
October 10, 2026 10:46
205976e to
09f067a
Compare
MrJs133
approved these changes
Oct 10, 2026
26 of 90 tasks
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A custom truststore previously allowed a trusted certificate with the wrong server identity. HTTPS requests now retain OkHttp's default hostname verification: trust alone is insufficient, and a matching DNS or IP Subject Alternative Name is required. The public
HostNameVerifier(String)constructor remains available.Main changes
cleanremoves.Verification
Fresh Java 17 compilation, targeted REST tests, style checks and independent reviews pass. The same handshake regression fails with the original verifier because the trusted, wrong-identity certificate is accepted.
Documentation
The Commons README documents the certificate requirement; the migration and contribution guides contain the accompanying corrections. Paired website documentation: apache/hugegraph-doc#511.