Repository navigation
fix: preserve int map entries during resize - #3341
Merged
Merged
Conversation
- hash keys against the captured table generation - retry removal after a competing chain update - verify parallel growth reads removals and size
3 of 11 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3341 +/- ##
============================================
- Coverage 54.31% 53.10% -1.21%
+ Complexity 2250 3 -2247
============================================
Files 770 503 -267
Lines 67952 48399 -19553
Branches 9213 6963 -2250
============================================
- Hits 36905 25704 -11201
+ Misses 27470 20082 -7388
+ Partials 3577 2613 -964 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pengzna
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Concurrent table growth could hash a key using one generation and access another, losing entries. A competing chain update could also make removal report an existing key as absent.
Main Changes
Hash against the captured table's length and retry a failed compare-and-set while the key is still present. Add parallel growth checks for reads, removals, retained values and final size.
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO: required documentation is pending; complete it before merging.Doc - Done: documentation is included here or linked below.Doc - No Need: no user-visible documentation is affected.Documentation files in this PR or paired hugegraph-doc PR:
Paired source PR: hugegraph#312
Conceptual overview
Conceptual illustration of generation-consistent hashing and removal retry after contention.
Conceptual illustration; not test or release-acceptance evidence.