Skip to content

tests: add parallel-instances spread test for components - #17809

Merged
maykathm merged 2 commits into
canonical:masterfrom
maykathm:SNAPDENG-37302-component-spread-test
Oct 14, 2026
Merged

maykathm merged 2 commits into
canonical:masterfrom
maykathm:SNAPDENG-37302-component-spread-test

Conversation

@maykathm

@maykathm maykathm commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@maykathm
maykathm requested review from andrewphelpsj and a balanced review from Copilot October 9, 2026 13:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Instance removal does not assert that its component blobs and mounts are cleaned up.

1 open finding
What changed in this PR

Adds spread coverage for component operations across parallel snap instances.

Changes:

  • Tests installation, removal, refresh, revert, hooks, and snapctl operations.
  • Adds local snap and component fixtures.
File Description
tests/​main/​component-parallel-instances/​task.yaml Adds parallel-instance component scenarios.
tests/​main/​component-parallel-instances/​snap-with-comps/​test Verifies component visibility.
tests/​main/​component-parallel-instances/​snap-with-comps/​meta/​snap.yaml Defines the test snap.
tests/​main/​component-parallel-instances/​comp1/​meta/​component.yaml Defines its test component.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

snap run test-snap-with-components_key one

echo "Removing an instance removes only its components"
snap remove --purge test-snap-with-components_key
@maykathm maykathm added this to the 2.79 milestone Oct 9, 2026
@maykathm
maykathm requested a review from natibek October 9, 2026 13:29
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.22%. Comparing base (01f4cca) to head (c23918f).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17809      +/-   ##
==========================================
- Coverage   82.26%   82.22%   -0.05%     
==========================================
  Files        1410     1411       +1     
  Lines      201153   201797     +644     
  Branches     2503     2626     +123     
==========================================
+ Hits       165485   165934     +449     
- Misses      33756    33855      +99     
- Partials     1912     2008      +96     
Flag Coverage Δ
unittests 82.22% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Tue Oct 13 17:45:18 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/38397255032

@andrewphelpsj andrewphelpsj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bboozzoo bboozzoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the Auto rerun spread Auto reruns spread up to 4 times in non-draft PRs w/ >=1 approval and <20 fails in any fund. system label Oct 13, 2026

@natibek natibek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@maykathm
maykathm merged commit c38df06 into canonical:master Oct 14, 2026
298 of 309 checks passed
@maykathm
maykathm deleted the SNAPDENG-37302-component-spread-test branch October 14, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto rerun spread Auto reruns spread up to 4 times in non-draft PRs w/ >=1 approval and <20 fails in any fund. system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants