Repository navigation
tests: new nightly workflow to check test snaps - #17844
Open
sergiocazzolato wants to merge 1 commit into
Open
sergiocazzolato wants to merge 1 commit into
sergiocazzolato wants to merge 1 commit into
Conversation
This nightly workflow checks if there are new test snaps which need to be registered under canonical account. Also check if test snaps have to be saved under tests/lib/snaps/store
ZeyadYasser
reviewed
Oct 16, 2026
| path: current/test-snaps.json | ||
| retention-days: 7 | ||
|
|
||
| - name: Download previous inventory |
Contributor
There was a problem hiding this comment.
shouldn't this go before "Upload current inventory" to avoid a race? are we sure workflow_runs[0] will always be the previous run?
| if snap["classification"] == store_classification and not belongs_to_canonical: | ||
| errors.append(f"{name}: store fixture is published by {publisher!r}") | ||
|
|
||
| if name.startswith("test-snapd-") and snap["classification"] == external_classification: |
Contributor
There was a problem hiding this comment.
some test snaps don't start with test-snapd-*, some only start with test-*
Suggested change
| if name.startswith("test-snapd-") and snap["classification"] == external_classification: | |
| if name.startswith("test-") and snap["classification"] == external_classification: |
Contributor
There was a problem hiding this comment.
we can add exceptions if we get false positives with the broader filter
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This nightly workflow checks if there are new test snaps which need to be registered under canonical account. Also check if test snaps have to be saved under tests/lib/snaps/store