Skip to content

Replace broken NARA video URL in Analyze_a_Video_Historic_Event_Recognition.ipynb - #1421

Merged
Giom-V merged 2 commits into
google-gemini:mainfrom
Giom-V:fix-video-historic-event-url
Oct 13, 2026
Merged

Giom-V merged 2 commits into
google-gemini:mainfrom
Giom-V:fix-video-historic-event-url

Conversation

@Giom-V

@Giom-V Giom-V commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Replaces the dead NARA S3 video URL with the copy hosted on the generativeai-downloads GCS bucket and updates the closing section heading for nblint.

Fixes #1417

@Giom-V
Giom-V requested a review from kkorpal October 13, 2026 07:15
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a broken external dependency in the historic event recognition notebook by migrating the source video to a reliable GCS bucket. Additionally, it includes a minor documentation adjustment to ensure the notebook adheres to project linting standards.

Highlights

  • Video URL Update: Replaced the broken NARA S3 video URL with a stable copy hosted on the generativeai-downloads GCS bucket.
  • Documentation Improvement: Updated the closing section heading in the notebook to 'Next steps' to comply with linting requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Oct 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the video source URL in the historic event recognition notebook to use Google Cloud Storage instead of Amazon S3, and renames the final section to "Next steps". Feedback is provided to ensure the video's source and license are explicitly mentioned in the markdown cell per the style guide, and to fully run the notebook to regenerate consistent execution outputs rather than manually editing them.

"## Example\n",
"\n",
"This example uses [video of President Ronald Reagan's Speech at the Berlin Wall](https://s3.amazonaws.com/NARAprodstorage/opastorage/live/16/147/6014716/content/presidential-libraries/reagan/5730544/6-12-1987-439.mp4) taken on June 12 1987."
"This example uses [video of President Ronald Reagan's Speech at the Berlin Wall](https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4) taken on June 12 1987."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository style guide, all external assets used in notebooks must have their source and license explicitly mentioned in the markdown cell that introduces them. Since this video is a public domain work from the National Archives and Records Administration (NARA), please update the description to explicitly state its source and license.

Suggested change
"This example uses [video of President Ronald Reagan's Speech at the Berlin Wall](https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4) taken on June 12 1987."
"This example uses a public domain [video of President Ronald Reagan's Speech at the Berlin Wall](https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4) from the National Archives and Records Administration (NARA) taken on June 12 1987."
References
  1. Always mention the source and license in the markdown cell that introduces the asset. (link)

"output_type": "stream",
"text": [
"--2025-03-04 14:04:54-- https://s3.amazonaws.com/NARAprodstorage/opastorage/live/16/147/6014716/content/presidential-libraries/reagan/5730544/6-12-1987-439.mp4\n",
"--2025-03-04 14:04:54-- https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4\n",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The saved output for the download cell has been manually edited to update the URL on line 124, but the subsequent lines (such as lines 125 and 126) still show resolving and connecting to s3.amazonaws.com. Please run the notebook fully to regenerate and save the correct, consistent outputs for the new Google Cloud Storage URL.

References
  1. Ideally we want the outputs to be saved in the notebooks so that one can see what the code does without running it. If none of them changed while some code has, it might be a sign that the notebook has not been run to check that it works. (link)

@Giom-V
Giom-V merged commit 921a5a8 into google-gemini:main Oct 13, 2026
11 checks passed
@Giom-V
Giom-V deleted the fix-video-historic-event-url branch October 13, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Big bug 🐛👎

2 participants