Repository navigation
Replace broken NARA video URL in Analyze_a_Video_Historic_Event_Recognition.ipynb - #1421
Conversation
…storic Event Recognition
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a broken external dependency in the historic event recognition notebook by migrating the source video to a reliable GCS bucket. Additionally, it includes a minor documentation adjustment to ensure the notebook adheres to project linting standards. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the video source URL in the historic event recognition notebook to use Google Cloud Storage instead of Amazon S3, and renames the final section to "Next steps". Feedback is provided to ensure the video's source and license are explicitly mentioned in the markdown cell per the style guide, and to fully run the notebook to regenerate consistent execution outputs rather than manually editing them.
| "## Example\n", | ||
| "\n", | ||
| "This example uses [video of President Ronald Reagan's Speech at the Berlin Wall](https://s3.amazonaws.com/NARAprodstorage/opastorage/live/16/147/6014716/content/presidential-libraries/reagan/5730544/6-12-1987-439.mp4) taken on June 12 1987." | ||
| "This example uses [video of President Ronald Reagan's Speech at the Berlin Wall](https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4) taken on June 12 1987." |
There was a problem hiding this comment.
According to the repository style guide, all external assets used in notebooks must have their source and license explicitly mentioned in the markdown cell that introduces them. Since this video is a public domain work from the National Archives and Records Administration (NARA), please update the description to explicitly state its source and license.
| "This example uses [video of President Ronald Reagan's Speech at the Berlin Wall](https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4) taken on June 12 1987." | |
| "This example uses a public domain [video of President Ronald Reagan's Speech at the Berlin Wall](https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4) from the National Archives and Records Administration (NARA) taken on June 12 1987." |
References
- Always mention the source and license in the markdown cell that introduces the asset. (link)
| "output_type": "stream", | ||
| "text": [ | ||
| "--2025-03-04 14:04:54-- https://s3.amazonaws.com/NARAprodstorage/opastorage/live/16/147/6014716/content/presidential-libraries/reagan/5730544/6-12-1987-439.mp4\n", | ||
| "--2025-03-04 14:04:54-- https://storage.googleapis.com/generativeai-downloads/videos/President_Ronald_Reagans_Speech_at_the_Berlin_Wall_1987-06-12.mp4\n", |
There was a problem hiding this comment.
The saved output for the download cell has been manually edited to update the URL on line 124, but the subsequent lines (such as lines 125 and 126) still show resolving and connecting to s3.amazonaws.com. Please run the notebook fully to regenerate and save the correct, consistent outputs for the new Google Cloud Storage URL.
References
- Ideally we want the outputs to be saved in the notebooks so that one can see what the code does without running it. If none of them changed while some code has, it might be a sign that the notebook has not been run to check that it works. (link)
Replaces the dead NARA S3 video URL with the copy hosted on the
generativeai-downloadsGCS bucket and updates the closing section heading fornblint.Fixes #1417