Repository navigation
Chore: Resolves #16119: Remove --no-sandbox checks in installation script - #16738
Merged
Merged
Conversation
…to runtime checks in AppImage stub
personalizedrefrigerator
approved these changes
Oct 3, 2026
personalizedrefrigerator
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me! I've tested locally on Ubuntu 26.04 (ARM, installer patched to use a local ARM64 AppImage build).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, deferring instead to runtime checks in AppImage stub
Background
Since upgrading to AppImage type 2 runtimes in #15043 - the
AppRunscript in the AppImage has been automatically applying--no-sandboxwhere required, independently of the.desktopscript. This PR removes the checks from the installation script, meaning the list doesn't have to be adjusted in the future simplifying the complexity. Additionally benefiting security in situations where users might adjust system policy to allow unprivileged user namespaces.Relevant AppImage Code
(run the AppImage with
--AppImage-extractand then opensquashfs-root/AppRun)Testing
Nice and easy;
--no-sandboxrequirements are most prominent, via shell (without a.desktopfile), showing--no-sandboxis now automatic in v3.7.desktopfile, and that the app continues to open without--no-sandboxbeing required inExec=