Repository navigation
Conversation
whoalin1
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
October 6, 2026 23:14
GVodyanov
reviewed
Oct 8, 2026
GVodyanov
left a comment
Contributor
There was a problem hiding this comment.
Hey! Thanks for the PR. I think u can use the share manager for this
$allowGroupSharing = $this->shareManager->allowGroupSharing();
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…isabled Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
whoalin1
force-pushed
the
fix/hide-groups-share-placeholder-when-disabled
branch
from
October 9, 2026 14:12
2a0d1f7 to
5b1448e
Compare
Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <207920491+whoalin1@users.noreply.github.com>
Author
|
@GVodyanov good call, switched to AI disclosure: this reply was drafted with help from an AI assistant. |
tcitworld
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an admin disables group sharing (
core/shareapi_allow_group_sharing), the calendar share search still said “Share with users or groups”.Expose that config via calendar initial state, load it into the settings store (same path as other server settings), and omit “groups” from the share search placeholder / empty state when the flag is false. Group principals are also filtered out of DAV sharee results in that case.
Closes #2946
Test plan
tests/php/unit/Service/CalendarInitialStateServiceTest.phptests/javascript/unit/store/settings.test.jsAI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.