Repository navigation
Add isPermaLink=false support to setPublicId() - #103
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Enhance item->setPublicId() for guid with isPermaLink=false
Add isPermaLink=false support to setPublicId()
Jul 19, 2026
Grotax
approved these changes
Sep 20, 2026
Grotax
marked this pull request as ready for review
September 20, 2026 07:07
Grotax
force-pushed
the
copilot/feature-enhance-item-set-public-id
branch
from
September 20, 2026 07:10
6e9cd91 to
2be53ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSS
<guid isPermaLink="false">allows non-URL identifiers, but the library had no way to set or preserve this attribute — guids were always emitted without it, forcing values to be valid URLs.Changes
NodeInterface/Node: Addedbool $isPermaLink = trueparameter tosetPublicId()and agetPublicIdIsPermaLink(): boolgetter. The flag is stored as$publicIdIsPermaLink(defaultstrue, fully backwards-compatible).Rule/PublicId::setProperty(): ReadsisPermaLinkattribute from parsed DOM element ('false'→false, anything else →true) and forwards it tosetPublicId(). Simplified the link-auto-set condition to use the resolved flag.Rule/PublicId::addElement(): EmitsisPermaLink="false"on the<guid>element when the flag isfalse; omits the attribute otherwise (RSS default istrue).Usage