Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
The
cookiesgetter inglobals.node.tshas no return type, so TypeScript 6 infers it fromMap#entries()and writesMapIterator<[string, Cookie]>intoglobals.node.d.ts.MapIteratoronly exists in the lib files of TypeScript 5.6 and later, so projects on an older compiler (like the Angular 17 client in the basic CRUD example, which uses TypeScript 5.2) fail withTS2552: Cannot find name 'MapIterator'unlessskipLibCheckis on.New behavior
The getter is annotated as
IterableIterator<[string, Cookie]>, which every TypeScript version understands. I checked that the regenerated.d.tscompiles cleanly with TypeScript 5.0 and 5.2.Other information (e.g. related issues)
Fixes #5567