Repository navigation
Preserve train departures when iRail fetching fails - #7
Merged
Merged
Conversation
timvandijck
marked this pull request as ready for review
October 12, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An iRail timeout or invalid response currently replaces a route’s stored departures with an empty list, making the tile go blank. Keep the last successful departures for failed routes while allowing successful routes to refresh. A successful empty response still clears the route.
Add a nullable fetch method that distinguishes failures from empty results while preserving the existing
getConnections()array contract. Store departure and destination identities to match cached routes after reordering or relabeling; use an unambiguous label fallback for data saved by older versions. Failures continue to be reported. Retained departures may be stale until the next successful fetch.Validation: 26 targeted tests passed (85 assertions), covering HTTP 429/503/504, network errors, invalid JSON and payloads, malformed departures, partial success, successful empty results, route changes, and legacy stored data.
git diff --checkpassed.