Skip to content

fix(i18n): correct Korean Reveal in Finder label - #26421

Closed
abruption wants to merge 1 commit into
stablyai:mainfrom
abruption:fix/ko-finder-reveal-label
Closed

abruption wants to merge 1 commit into
stablyai:mainfrom
abruption:fix/ko-finder-reveal-label

Conversation

@abruption

@abruption abruption commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Korean menus describe revealing an item in Finder as making it public. This corrects the label to “Finder에서 보기” (“Show in Finder”).

What Changed

Changes one Korean translation used by the file explorer, editor header, and file-tab menus: “Finder에 공개” → “Finder에서 보기”.

Why

The action calls shell.showItemInFolder. “보기” describes that behavior and matches existing Korean wording in Orca. Updating the shared translation keeps all three menus consistent.

Linked Issue

Fixes #26420

Visual Proof

Before After
Before: Finder에 공개 After: Finder에서 보기

Before/after screenshots were captured from the actual Orca Dev file-explorer context menu on macOS, in Korean with the dark theme. Both labels render without clipping.

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

On macOS: localization catalog verification, oxfmt --check, lint-staged, and git diff --check passed. No new test was added for this single translation value. Orca Dev was built and launched for the before/after UI check through Playwright CDP. Full lint, typecheck, test, and production build were not run.

AI Disclosure

OpenAI Codex (GPT-6) assisted with implementation and source review.

Review

Source review confirmed that the macOS label reaches all three menus through the shared helper. Windows/Linux labels, local/SSH routing, agents, integrations, and git providers retain their existing behavior. The change adds no executable logic or performance/security exposure. The file-explorer menu was checked in the running Orca Dev app; the corrected label fits without clipping.

Agent skill upstream boundary

  • Not applicable; no upstream skill content is copied.

Author

GitHub: @abruption. X/Twitter: @abruptWave.

Notes

Scope: one Korean catalog value; no runtime or wire-format change.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: df24d1df-f725-4e41-92b3-444aafce4a0c
📥 Commits

Reviewing files that changed from the base of the PR and between d0e729c and 576e173.

📒 Files selected for processing (1)
  • src/renderer/src/i18n/locales/ko.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Korean file-explorer label for revealInFinder changed from “Finder에 공개” to “Finder에서 보기.” No other behavior changed.

Priority: ⬇️ Low

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 576e1

The Korean menu label now describes showing an item in Finder rather than publishing it. No material merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the required sections, linked issue, user-facing change, rationale, testing notes, and checklist. However, it conflicts with the PR objectives, which state that manual testing… Reconcile the testing and visual-proof claims. Confirm whether manual UI testing was performed and attach valid before/after screenshots, or update the description to state that they were not performed or attached.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed The description references issue #26420, and the issue objective matches the translation change.
Out of Scope Changes check ✅ Passed The one-line Korean catalog change matches the stated objective. No unrelated behavior or runtime changes are reported.
Title check ✅ Passed The title clearly identifies the Korean localization fix for the Reveal in Finder label.
Full details: Description check

Explanation

The description includes the required sections, linked issue, user-facing change, rationale, testing notes, and checklist. However, it conflicts with the PR objectives, which state that manual testing and a rendered after screenshot were not provided.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nwparker added a commit that referenced this pull request Oct 9, 2026
Records the retained adapted contribution from #26421 in replacement PR #26866.

Co-authored-by: YEONGUK LEE <contact@abruption.dev>
@nwparker

Copy link
Copy Markdown
Contributor

Closing this PR as superseded by the merged PR #26866. It retains the exact Korean Finder label correction and also updates the existing override table so catalog regeneration preserves it. YEONGUK LEE’s retained contribution is credited as a co-author.

@nwparker nwparker closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Korean Reveal in Finder label implies publishing

2 participants