Repository navigation
Conversation
#26422 removed the local-branch-deleted toast's call site but left its two keys in en.json, so the runtime-required catalog no longer covered en.json and the localization check fails on main. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughAdded English translations for the worktree messages “Local branch deleted” and Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The change restores the two required English catalog entries. No material merge risk is evident from the supplied context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The translation check fails on main for every PR. This regenerates one generated file so it passes again.
What Changed
#26422 removed the "Local branch deleted" toast's code, but its two text keys are still in
en.json.Keys with no call site have to be listed in
src/renderer/src/i18n/en-runtime-required.json, soverify-localization-catalogsnow fails on every PR's "Verify localization catalogs" step. This runs therepo's own fixer,
node config/scripts/generate-runtime-required-english-catalog.mjs --fix(the step'ssuggested
sync:localization-runtime-catalog), which adds the two keys. Nothing else changes.Why
This is the fix the failing check itself prescribes, and the smallest change that turns main green again.
Pruning the now-unused keys from every locale would also work, but it touches six translation files.
Linked Issue
N/A (maintainer)
Visual Proof
N/A. Generated catalog only.
Testing
Automated tests added/updated, or explained why not below
On
origin/main,bun config/scripts/verify-localization-catalogs.mjsexits 1 with"en-runtime-required.json no longer covers en.json".
With this change it exits 0.