Skip to content

fix(i18n): regenerate the runtime English catalog after #26422 - #26432

Open
Jinwoo-H wants to merge 1 commit into
mainfrom
fix/i18n-runtime-catalog-after-26422
Open

Jinwoo-H wants to merge 1 commit into
mainfrom
fix/i18n-runtime-catalog-after-26422

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​2

ELI5

The translation check fails on main for every PR. This regenerates one generated file so it passes again.

What Changed

#26422 removed the "Local branch deleted" toast's code, but its two text keys are still in en.json.
Keys with no call site have to be listed in src/renderer/src/i18n/en-runtime-required.json, so
verify-localization-catalogs now fails on every PR's "Verify localization catalogs" step. This runs the
repo's own fixer, node config/scripts/generate-runtime-required-english-catalog.mjs --fix (the step's
suggested sync:localization-runtime-catalog), which adds the two keys. Nothing else changes.

Why

This is the fix the failing check itself prescribes, and the smallest change that turns main green again.
Pruning the now-unused keys from every locale would also work, but it touches six translation files.

Linked Issue

N/A (maintainer)

Visual Proof

N/A. Generated catalog only.

Testing

  • Automated tests added/updated, or explained why not below

  • On origin/main, bun config/scripts/verify-localization-catalogs.mjs exits 1 with
    "en-runtime-required.json no longer covers en.json".

  • With this change it exits 0.

#26422 removed the local-branch-deleted toast's call site but left its two keys in en.json, so the
runtime-required catalog no longer covered en.json and the localization check fails on main.

Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b95b6a7a-3293-4cdc-886d-1703200f1eda
📥 Commits

Reviewing files that changed from the base of the PR and between 00a8250 and 96d862e.

📒 Files selected for processing (1)
  • src/renderer/src/i18n/en-runtime-required.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Added English translations for the worktree messages “Local branch deleted” and Deleted "{{value0}}".

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 96d86

The change restores the two required English catalog entries. No material merge risk is evident from the supplied context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the focused change: regenerating the runtime English catalog after PR #26422.
Description check ✅ Passed The description includes the ELI5, change, rationale, linked issue exception, visual proof, and testing sections. It clearly explains the affected catalog entries and verification command. Some option…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant