Repository navigation
TanStack: Add strictMode to FrameworkOptions type - #36712
BaconMan1168 wants to merge 1 commit into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughTanStack React ChangesFramework options
Priority: ⬇️ Low Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The new option type matches the existing runtime behavior. No actionable merge risk remains. ✨ Finishing Touches 💡 1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thanks for the quick fix, @BaconMan1168! Adding Stages: architecture (stage 1) and code quality (stage 2) were skipped because the change is a two-line optional type field. Runtime verification (stage 3) ran on What we checked:
Not covered: a production A maintainer will make the final decision on merging. |
Closes #36711
What I did
Added
strictMode?: booleanto theFrameworkOptionstype in@storybook/tanstack-react, matching@storybook/react-vite.The option already works at runtime. builder-vite writes the framework options into
FRAMEWORK_OPTIONS, and the React renderer readsstrictModefrom there. Only the type was missing, soframework: { name: '@storybook/tanstack-react', options: { strictMode: true } }failed to typecheck with TS2353.This PR was drafted with AI assistance (Claude Code). I reviewed the change and stand behind it.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
code/frameworks/tanstack-react/src/containing:yarn nx check tanstack-react.nextthis reportsTS2353: 'strictMode' does not exist in type 'FrameworkOptions'.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.