Skip to content

Remove local branch deletion success notification - #26422

Merged
nwparker merged 1 commit into
mainfrom
nwparker/force-del-dialog
Oct 8, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/force-del-dialog

Conversation

@nwparker

@nwparker nwparker commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 0 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9

ELI5

Deleting a preserved local branch no longer produces an extra success notification.

What Changed

Remove the success toast from the preserved-branch deletion action. The warning with its Force Delete Branch button and failure notifications still work; successful deletion now quietly dismisses the warning.

Why

The extra confirmation adds little value after an explicit deletion. Removing it at the action keeps local and remote callers consistent without changing branch cleanup or hiding failures.

Linked Issue

Requested directly by a maintainer; no existing issue.

Visual Proof

Captured through Playwright CDP in a hidden macOS Orca instance against a disposable Git repository. Both runs clicked the actual Force Delete Branch button and deleted the Git branch.

Before:

Before: extra success notification

After:

After: deletion finishes without another notification

Testing

  • I manually tested these changes locally
  • Automated tests added/updated, or explained why not below

31 existing tests pass across preserved-branch metadata, remote deletion routing, and batch notifications. Renderer typecheck and file lint pass. No new test is needed for removing a success toast. During the rendered after run, a DOM observer verified that the success message never appeared, and Git confirmed the branch was deleted.

Rendered validation ran on macOS; remote routing was covered by existing unit tests. Linux, Windows, and live SSH were not exercised. Full lint and build are left to CI; the dev main/preload builds passed.

Review

Self-reviewed: only the success toast was removed. Failure reporting, retained cleanup routes, and deletion results are unchanged.

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

No platform-specific behavior, paths, shortcuts, remote wire changes, or mobile changes.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

@nwparker
nwparker merged commit 8b20d21 into main Oct 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant