Repository navigation
Remove local branch deletion success notification - #26422
Merged
Merged
Conversation
8 tasks done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Deleting a preserved local branch no longer produces an extra success notification.
What Changed
Remove the success toast from the preserved-branch deletion action. The warning with its Force Delete Branch button and failure notifications still work; successful deletion now quietly dismisses the warning.
Why
The extra confirmation adds little value after an explicit deletion. Removing it at the action keeps local and remote callers consistent without changing branch cleanup or hiding failures.
Linked Issue
Requested directly by a maintainer; no existing issue.
Visual Proof
Captured through Playwright CDP in a hidden macOS Orca instance against a disposable Git repository. Both runs clicked the actual Force Delete Branch button and deleted the Git branch.
Before:
After:
Testing
31 existing tests pass across preserved-branch metadata, remote deletion routing, and batch notifications. Renderer typecheck and file lint pass. No new test is needed for removing a success toast. During the rendered after run, a DOM observer verified that the success message never appeared, and Git confirmed the branch was deleted.
Rendered validation ran on macOS; remote routing was covered by existing unit tests. Linux, Windows, and live SSH were not exercised. Full lint and build are left to CI; the dev main/preload builds passed.
Review
Self-reviewed: only the success toast was removed. Failure reporting, retained cleanup routes, and deletion results are unchanged.
Agent skill upstream boundary
Notes
No platform-specific behavior, paths, shortcuts, remote wire changes, or mobile changes.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)